add timeout to influx db #40439
add timeout to influx db #40439
Conversation
|
Hmm. I guess we should add (or modify) existing test to test for it. I find it highly suspicious when such changes pass without any test modifications - it makes me think some tests are missing. |
| ``token``: (required) `Create token <https://docs.influxdata.com/influxdb/cloud/security/tokens/create-token/>`_ | ||
| using the influxdb cli or UI | ||
|
|
||
| ``org_name``: (required) `Create org <https://docs.influxdata.com/influxdb/cloud/reference/cli/influx/org/create/>`_ |
There was a problem hiding this comment.
If token and org name are required lets customize the Ui form for to have them. Its much nicer than passing them as kwargs
There was a problem hiding this comment.
@romsharon98 i think we shouldnt remove this but just mention its not defined via extra.
This is what we do in other providers as well
https://airflow.apache.org/docs/apache-airflow-providers-google/stable/connections/bigquery.html#configuring-the-connection
Yes, you were right. The tests didn't check much (or at all). I've updated them. |
|
Cool. Thanks! |
The apache#40439 introduced new attributes for influxdb widgets, with the InputRequired validator, which should not be used on connection fields, because the fields are all present in the form for all connection types, and they are just "hidden" dynamically per connection type. This PR removes InputRequired validation for those
The #40439 introduced new attributes for influxdb widgets, with the InputRequired validator, which should not be used on connection fields, because the fields are all present in the form for all connection types, and they are just "hidden" dynamically per connection type. This PR removes InputRequired validation for those
…#40469) The apache#40439 introduced new attributes for influxdb widgets, with the InputRequired validator, which should not be used on connection fields, because the fields are all present in the form for all connection types, and they are just "hidden" dynamically per connection type. This PR removes InputRequired validation for those
passing extra to influxDB.
close this thread in slack:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.