Fix failure of "Add connection" introduced by influxdb change #40469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apache#40439 introduced new attributes for influxdb widgets, with the InputRequired validator, which should not be used on connection fields, because the fields are all present in the form for all connection types, and they are just "hidden" dynamically per connection type. This PR removes InputRequired validation for those
ephraimbuddy
approved these changes
Jun 27, 2024
Merged
52 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…#40469) The apache#40439 introduced new attributes for influxdb widgets, with the InputRequired validator, which should not be used on connection fields, because the fields are all present in the form for all connection types, and they are just "hidden" dynamically per connection type. This PR removes InputRequired validation for those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #40439 introduced new attributes for influxdb widgets, with the InputRequired validator, which should not be used on connection fields, because the fields are all present in the form for all connection types, and they are just "hidden" dynamically per connection type. This PR removes InputRequired validation for those
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.