Add try_number to log table #40739
Add try_number to log table #40739
Conversation
boring-cyborg
bot
added
area:db-migrations
hussein-awala
added
type:new-feature
Needed in order to be able to associate log records with specific TI try.
dstandish
force-pushed
the
add-try-number-to-log-table
branch
from
efb813e
to
32b5f93
Compare
dstandish
requested review from
ryanahamilton,
bbovenzi,
pierrejeambrun and
ephraimbuddy
as code owners
There was a problem hiding this comment.
Once comment I had before - this will likely get people some new/unexpected records if they are using the API, but the likeloihood of it is small, so that would not be too breaking (and it could be easily workarounded by try_number not set. If that does not bother others - I am fine with it too
Yeah I think getting more information has to be expected on the part of users, and the other way around would probably be more breaking! (i.e. not emitting certain events). but still maybe not really breaking even in that case. |
|
the one static check failure is in main; merging |
Forgot to add these in #40739
This is needed in order to be able to associate log records with specific TI try, and to connect the events with specific TIs in the UI.
…#40845) Forgot to add these in apache#40739
Needed in order to be able to associate log records with specific TI try.
NOTE I'm actually somewhat tempted to just create a separate log table for this kind of thing, e.g.task_instance_event_log. Being smaller and having a narrower focus has advantages. WDYT?After talking with @bbovenzi I'm going back to this approach. I.e. just enhance the existing log table to make it work better for this use case. There will be a couple followup PRs for the UI parts and for getting rid of task context logger.