Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT Add task instance event log table #40761

Closed
wants to merge 3 commits into from
Closed

DRAFT Add task instance event log table #40761

wants to merge 3 commits into from

Conversation

dstandish
Copy link
Contributor

draft!

@boring-cyborg boring-cyborg bot added area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler provider:amazon-aws AWS/Amazon - related issues labels Jul 12, 2024
@dstandish dstandish changed the title Add task instance event log table DRAFT Add task instance event log table Jul 12, 2024
vincbeck
vincbeck reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Should we also deprecate/remove TaskContextLogger ?

airflow/api_connexion/schemas/event_log_schema.py Outdated
class EventLogCollection(NamedTuple):
"""List of import errors with metadata."""

event_logs: list[Log]
total_entries: int

class TaskInstanceEventLogCollection(NamedTuple):
"""List of import errors with metadata."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasta

airflow/providers/amazon/aws/executors/ecs/ecs_executor.py Outdated
task_key,
reasons_str = ", ".join(failure_reasons)
self.log.error(
"ECS task %s has failed %s times. Marking as failed. Reasons: %s" % task_key,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ECS task %s has failed %s times. Marking as failed. Reasons: %s" % task_key,
"ECS task %s has failed %s times. Marking as failed. Reasons: %s",

And pass task_key as first parameter

@dstandish
Copy link
Contributor Author

closing in favor of #40739

@dstandish dstandish closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincbeck vincbeck vincbeck left review comments

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton will be requested when the pull request is marked ready for review ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb will be requested when the pull request is marked ready for review ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi will be requested when the pull request is marked ready for review bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun will be requested when the pull request is marked ready for review pierrejeambrun is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl will be requested when the pull request is marked ready for review jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy will be requested when the pull request is marked ready for review ephraimbuddy is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk will be requested when the pull request is marked ready for review potiuk is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG will be requested when the pull request is marked ready for review XD-DENG is a code owner

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas will be requested when the pull request is marked ready for review o-nikolas is a code owner

@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala will be requested when the pull request is marked ready for review hussein-awala is a code owner

Assignees
No one assigned
Labels
area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstandish @vincbeck