Bump minimum version for azure containerinstance. #40767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apache#40616 used priority for ContainerGroup and it has only been added in 10.1.0 version of azure-containerinstance library See https://pypi.org/project/azure-mgmt-containerinstance/10.1.0/
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
|
Detected by canary builds. |
eladkal
approved these changes
Jul 13, 2024
Yes.I am trying to see if we can do it on all PRs in a selective way here: #40768 - becaue currently "special" tests are not run on most of regular PR (which is good), but the "lowest dependency" tests should also run there, I think in all PRs (though they are considerably slower than regular tests so there is a trade-off). |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 13, 2024
Previously lowest-dependency tests were only run as part of "special" tests - which means that they were not run on regular PRs which did not touch dependencies. But those tests should also be run on regular PRs even if the PR does not change dependencies - because just using a new feature might cause lowest dependencies to fail (Similarly as in apache#40767
|
Yep #40768 should fix it - I was afraid we will hit the workflow limit when I separate it out, but seems that we are not, so it's good to go. |
potiuk
added a commit
that referenced
this pull request
Jul 13, 2024
Previously lowest-dependency tests were only run as part of "special" tests - which means that they were not run on regular PRs which did not touch dependencies. But those tests should also be run on regular PRs even if the PR does not change dependencies - because just using a new feature might cause lowest dependencies to fail (Similarly as in #40767
ephraimbuddy
added
the
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
The apache#40616 used priority for ContainerGroup and it has only been added in 10.1.0 version of azure-containerinstance library See https://pypi.org/project/azure-mgmt-containerinstance/10.1.0/
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Previously lowest-dependency tests were only run as part of "special" tests - which means that they were not run on regular PRs which did not touch dependencies. But those tests should also be run on regular PRs even if the PR does not change dependencies - because just using a new feature might cause lowest dependencies to fail (Similarly as in apache#40767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #40616 used priority for ContainerGroup and it has only been added in 10.1.0 version of azure-containerinstance library
See https://pypi.org/project/azure-mgmt-containerinstance/10.1.0/
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.