Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lowest-dependencies test to separate workflow #40768

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 13, 2024

Previously lowest-dependency tests were only run as part of
"special" tests - which means that they were not run on
regular PRs which did not touch dependencies. But those tests
should also be run on regular PRs even if the PR does not change
dependencies - because just using a new feature might cause
lowest dependencies to fail (Similarly as in #40767


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk marked this pull request as ready for review July 13, 2024 17:44
@potiuk potiuk requested review from ashb and kaxil as code owners July 13, 2024 17:44
@potiuk potiuk requested a review from eladkal July 13, 2024 17:44
Previously lowest-dependency tests were only run as part of
"special" tests - which means that they were not run on
regular PRs which did not touch dependencies. But those tests
should also be run on regular PRs even if the PR does not change
dependencies - because just using a new feature might cause
lowest dependencies to fail (Similarly as in apache#40767
@potiuk potiuk force-pushed the lowest-direct-workflow-moved branch from 6d7489a to 1b91e52 Compare July 13, 2024 17:47
@potiuk
Copy link
Member Author

potiuk commented Jul 13, 2024

We also have another issue with "yield_per" - but that one is kinda tricky.

@potiuk potiuk merged commit f399c4a into apache:main Jul 13, 2024
67 of 77 checks passed
@potiuk potiuk deleted the lowest-direct-workflow-moved branch July 13, 2024 18:23
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 23, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.10.0 milestone Jul 23, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Previously lowest-dependency tests were only run as part of
"special" tests - which means that they were not run on
regular PRs which did not touch dependencies. But those tests
should also be run on regular PRs even if the PR does not change
dependencies - because just using a new feature might cause
lowest dependencies to fail (Similarly as in apache#40767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants