Add log_url to OpenLineage AirflowRunFacet #40797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
mobuchowski
approved these changes
Jul 15, 2024
kacpermuda
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: OpenLineage/OpenLineage#2852
It is quite useful to have an URL of Airflow task log as a part of
AirflowRunFacet. Currently I have to reimplement the logic present in Airflow on OpenLineage backend side, and keep it in sync with a particular Airflow version, e.g.:https://github.com/apache/airflow/blob/2.9.0/airflow/models/taskinstance.py#L1719-L1731
https://github.com/apache/airflow/blob/2.1.0/airflow/models/taskinstance.py#L524-L528
Add TaskInstances's
log_urlfield toAirflowRunFacet.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.