-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tasks API endpoint tests for DAG without start_date #40881
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Build is failing due to a KeyError in breeze selective checks here. But this PR has only API-related tests (no Provider-related code changes). Could this be a bug @potiuk? The breeze selective checks code is breaking here in this build, as Update: I've fixed this KeyError issue in this PR so it can be tested and verified here itself. Let me know if I should move it to a PR of it's own. Thanks. |
de2e7bb
to
10495d3
Compare
I separated out the fix in Breeze @omkar-foss (and did it slightly differently and added tests covering more cases). #40904 |
( I made you co-author) |
We were removing "Providers" from the list of candidates and handled the key non-existing but there were a path when splitting to individual provider tests for "compatibility checks" was failing. This is split from apache#40881 and test is added. Co-authored-by: Omkar P <45419097+omkar-foss@users.noreply.github.com>
We were removing "Providers" from the list of candidates and handled the key non-existing but there were a path when splitting to individual provider tests for "compatibility checks" was failing. This is split from #40881 and test is added. Co-authored-by: Omkar P <45419097+omkar-foss@users.noreply.github.com>
You can rebase on top of main and remove your changes - it should work now @omkar-foss |
10495d3
to
a911e66
Compare
Thanks for looking into this @potiuk. Done, I've rebased this PR with @jedcunningham this is a tests-only PR supporting the change in your PR #40878, please have a look whenever you get a minute, thanks. |
a911e66
to
e06a7ee
Compare
e06a7ee
to
b6a772b
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…he#40904) We were removing "Providers" from the list of candidates and handled the key non-existing but there were a path when splitting to individual provider tests for "compatibility checks" was failing. This is split from apache#40881 and test is added. Co-authored-by: Omkar P <45419097+omkar-foss@users.noreply.github.com>
related: #40828
This PR adds tests to cover Tasks API endpoint cases where the DAG doesn't have a
start_date
and is defined withschedule=None
(it's unscheduled). Tests in this PR support the fix in #40878.Additionally, this PR fixes theUpdate: This is fixed in #40904.Provider
KeyError that occurs in breeze selective checks for API tests as mentioned in the comment below.