Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure of selective checks when only API has been modified #40904

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 20, 2024

We were removing "Providers" from the list of candidates and handled the key non-existing but there were a path when splitting to individual provider tests for "compatibility checks" was failing.

This is split from #40881 and test is added.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

We were removing "Providers" from the list of candidates and
handled the key non-existing  but there were a path when splitting to
individual provider tests for "compatibility checks" was failing.

This is split from apache#40881 and test is added.

Co-authored-by: Omkar P <45419097+omkar-foss@users.noreply.github.com>
@potiuk potiuk force-pushed the fix-error-if-only-api-is-modified branch from 4cf90b1 to 2745a38 Compare July 20, 2024 14:20
@potiuk potiuk merged commit f099bea into apache:main Jul 20, 2024
76 checks passed
@potiuk potiuk deleted the fix-error-if-only-api-is-modified branch July 20, 2024 14:50
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…he#40904)

We were removing "Providers" from the list of candidates and
handled the key non-existing  but there were a path when splitting to
individual provider tests for "compatibility checks" was failing.

This is split from apache#40881 and test is added.

Co-authored-by: Omkar P <45419097+omkar-foss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants