Fix ApiException handling when adopting completed pods #41109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to complete adopted pods, if we encounter an ApiException, we should assume we were unable to adopt the pod meaning we shouldn't add that to our `running` set. If we do, `running` can fill up over time with tasks the executor isn't actually watching.
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
potiuk
reviewed
Jul 30, 2024
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
Jul 30, 2024
kaxil
approved these changes
Jul 30, 2024
eladkal
approved these changes
Jul 30, 2024
ephraimbuddy
approved these changes
Jul 31, 2024
molcay
pushed a commit
to VladaZakharova/airflow
that referenced
this pull request
Aug 19, 2024
When trying to complete adopted pods, if we encounter an ApiException, we should assume we were unable to adopt the pod meaning we shouldn't add that to our `running` set. If we do, `running` can fill up over time with tasks the executor isn't actually watching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to complete adopted pods, if we encounter an ApiException, we should assume we were unable to adopt the pod meaning we shouldn't add that to our
runningset. If we do,runningcan fill up over time with tasks the executor isn't actually watching.cc @wolfier