Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ApiException handling when adopting completed pods #41109

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix ApiException handling when adopting completed pods #41109

merged 2 commits into from
Jul 31, 2024

Commits on Jul 30, 2024

  1. Fix ApiException handling when adopting completed pods 

    When trying to complete adopted pods, if we encounter an ApiException,
we should assume we were unable to adopt the pod meaning we shouldn't
add that to our `running` set. If we do, `running` can fill up over time
with tasks the executor isn't actually watching.
    @jedcunningham
    jedcunningham committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f542f95 View commit details
    Browse the repository at this point in the history

  2. continue vs else

    @jedcunningham
    jedcunningham committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    fd1fc15 View commit details
    Browse the repository at this point in the history