-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook #41916
base: main
Are you sure you want to change the base?
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
You will have to:
|
Whoops... Sorry. 🙏🏻 |
@Illumaria can you address the needed changes? I'm hoping to include this PR in the next release |
needs rebase and resolve conflicts |
@eladkal Sure, I’ll do it by the end of the weekend. |
@eladkal Hi! Could you please help me understand what I should do to fix the failing tests? :( |
There are regular unit tests failing and they should be fixed. For compatibility tests - when they fail, they point you with the link to the documentation that desribes possible approaches and shows some examples how to deal with compatibility tests, and there are a number of examples already implemented in the code: |
|
@Illumaria were you able to work on fixing the test? |
No, not yet. :( I’m away from home now, will be back on September 30th. Good news is I kinda need these changes for my work, so I won’t leave this request unfinished. |
Closes #34828