-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for semicolon stripping to DbApiHook, PrestoHook, and TrinoHook #41916
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
You will have to:
|
Whoops... Sorry. 🙏🏻 |
@Illumaria can you address the needed changes? I'm hoping to include this PR in the next release |
needs rebase and resolve conflicts |
@eladkal Sure, I’ll do it by the end of the weekend. |
Rebased after merging #43913 |
The above test failures are due to using |
Uhm... Is this a network issue on GitHub side? O_o
|
Yeah.... Happens |
We (committers) can re-start that one failed job later after this PR completes all other checks. |
@potiuk Could you please re-run the failed test job? I don't think I have the rights. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE! finally!
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Wooooohooo! (CC: @eladkal ) |
Thanks @Illumaria for the patience. It was not an easy one and it uncovered a number of edge-cases in our CI that we had to fix :) #protm |
Great work @Illumaria 👏🏻👏🏻 |
…noHook (apache#41916) --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
…noHook (apache#41916) --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Closes: #34828