Bump min version of sqlparse to 0.5.1 #43961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Nov 13, 2024
potiuk
approved these changes
Nov 13, 2024
|
Yeah. I really like how the "lowest dependency" tests are keeping thing in order - this is a result of #41916 telling us "Not good version" :) |
potiuk
reviewed
Nov 13, 2024
| @@ -421,7 +421,7 @@ | |||
| "deps": [ | |||
| "apache-airflow>=2.8.0", | |||
| "more-itertools>=9.0.0", | |||
| "sqlparse>=0.4.2" | |||
| "sqlparse>=0.5.1" | |||
There was a problem hiding this comment.
I see now that 5f94f33 was added so we can close this one. Had problems with pushing commit to the author fork
There was a problem hiding this comment.
Yeah. I like it better too - this one would be linked via comment but not "straightforward" really. If I search with git blame for example, it would show me much more reasoning in the single commit that I'd find, without looking for the "related" one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to bump it anyway to unblock #41916 so raised PR to expedite things