[AIRFLOW-3569] Add "Trigger DAG" button in DAG page #4373
Conversation
To have the Manual Trigger DAG button in the DAG page as well, rather than only in the home page.
XD-DENG
force-pushed
the
add_trigger_button_in_dag_page
branch
from
f350974
to
53806ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #4373 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 202 202
Lines 16486 16486
=======================================
Hits 12883 12883
Misses 3603 3603Continue to review full report at Codecov.
|
|
thanks for the change. But I am not sure if I like this change. 1. From UI perspective, there will be two places to do the triggering dag which is kinda redundant; 2. The DAG page is a page for DAG information, not for operation(delete dag run, modify dag run, trigger dag run are in a different page). If we add this button, I think people may also argue whether we should add a stop dag run, modify dag run etc button(which are operations related to the dag) to this page. Just my 2cents. |
|
Thanks @feng-tao . Fully understand your point/concern. However, I think from UI perspective it may still be worth adding it, in order to be consistent with the But I also agree the value added by this change is not that big. I would like to leave the decision to you & other committers. Thanks! And happy new year! |
|
@feng-tao got good points on why not to do this but I have to agree to @XD-DENG we could at least have the same Moreover the |
|
Hi @ashb , a gentle ping: may you advise on this UI change PR? Thanks. |
|
I think it makes sense to have the same links on the list and detail pages - and haven't been annoyed by the lack of trigger, but I have wanted other options that were missing, so I'm +1 |
…pache#4373) To have the Manual Trigger DAG button in the DAG page as well, rather than only in the home page.
…pache#4373) To have the Manual Trigger DAG button in the DAG page as well, rather than only in the home page.
…pache#4373) To have the Manual Trigger DAG button in the DAG page as well, rather than only in the home page.
…he#4373) This is a back-ported version of the change introducted to the RBAC ui in apache#4373.
…pache#4373) To have the Manual Trigger DAG button in the DAG page as well, rather than only in the home page.
Jira
Description
What this PR is addressing?
Currently, the (manual) Trigger DAG button is only available at the /home page.
But I always encounter this situation: when I'm checking the tree view, or code, or graph view of a specific DAG, I may want to manually trigger another DagRun. I need to go back to the home page, search for that DAG, trigger the DagRun, then click it again to check the tree view.
It may be good if we can have the Manual Trigger DAG button in the DAG page as well, rather than only in the home page.
Others
This PR only updated
/www_rbac. Given deprecating old UI (/www) is already in the plan ([AIRFLOW-3303] Deprecate old UI in favor of FAB #4339), updating/wwwmay add extra re-basing work for [AIRFLOW-3303] Deprecate old UI in favor of FAB #4339. But kindly let me know if any committer finds it's still necessary to update/www.After the DagRun is triggered, users will be re-directed back to the
Tree-Viewtab of the DAG that was triggered.Screenshots