Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4160] Fix redirecting of 'Trigger Dag' Button in DAG Page (.vs v1-10-stable) #4982

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Mar 26, 2019

This PR is for branch 1-10-stable only.

Jira

Description

"Trigger Dag" Button in DAG Page was added in #4373

but it was broken by #4643

This issue is found in the testing process of 1.10.3b1 .

Tests

Tested locally and the fix is working

@XD-DENG
Copy link
Member Author

XD-DENG commented Mar 26, 2019

@ashb PTAL. This PR is for branch 1-10-stable.

@ashb
Copy link
Member

ashb commented Mar 26, 2019

Do we have a similar one for master too? Ah yes 4981

@codecov-io
Copy link

codecov-io commented Mar 27, 2019

Codecov Report

Merging #4982 into v1-10-stable will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           v1-10-stable    #4982      +/-   ##
================================================
+ Coverage         77.87%   78.07%   +0.19%     
================================================
  Files               221      221              
  Lines             17528    18110     +582     
================================================
+ Hits              13650    14139     +489     
- Misses             3878     3971      +93
Impacted Files Coverage Δ
airflow/operators/mysql_operator.py 79.16% <0%> (-20.84%) ⬇️
airflow/utils/decorators.py 84.48% <0%> (-7.19%) ⬇️
airflow/utils/dag_processing.py 56.17% <0%> (-2.81%) ⬇️
airflow/operators/redshift_to_s3_operator.py 92.98% <0%> (-2.58%) ⬇️
airflow/configuration.py 89.04% <0%> (-0.18%) ⬇️
airflow/operators/oracle_operator.py 0% <0%> (ø) ⬆️
airflow/sensors/hdfs_sensor.py 100% <0%> (ø) ⬆️
airflow/operators/s3_to_redshift_operator.py 100% <0%> (ø) ⬆️
airflow/models/__init__.py 92.72% <0%> (+0.04%) ⬆️
airflow/hooks/hive_hooks.py 75.45% <0%> (+0.12%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9b0fb...7ac493e. Read the comment docs.

@XD-DENG
Copy link
Member Author

XD-DENG commented Mar 27, 2019

@ashb CI passed. Please take a look.

Another PR with the same change against master branch (#4981) was already merged by Feng Tao.

@ashb ashb merged commit d1d97a2 into apache:v1-10-stable Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants