Make list backfills endpoint use asyncio #44208
Open
+256
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
changed the title
There was a problem hiding this comment.
Looks nice.
Just a few small suggestions.
Also I realized that we cannot have 'lazy' loading of some attributes at serialization time (when using pydantic), because this will be 'uncontroled async I/O'.
I don't know if you are encountering this on the Backfill model, but basically it means that everything needs to be eager loaded before, so pydantic does not emit uncontrolled request afterwards. (and unfortunatly we cannot await BackfillResponse.model_validate)
Also just to mention that there is a stream API to iterate over multiple results. That could be interesting to see if this can help us here.
dstandish
force-pushed
the
poc-async-route-fastapi
branch
from
74cbd14
to
1efe639
Compare
This enables us to have simpler API code, since we don't need to call `model_validate` as much.
dstandish
force-pushed
the
poc-async-route-fastapi
branch
2 times, most recently
from
c2eb8e2
to
a9c6980
Compare
dstandish
force-pushed
the
poc-async-route-fastapi
branch
from
a9c6980
to
f835db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sort of hello world / proof of concept for having an route implemented using asyncio.
Depends on #44226