Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filters param optional and fix typing #44226

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Make filters param optional and fix typing #44226

merged 1 commit into from
Nov 21, 2024
+59 −55

Conversation

dstandish
Copy link
Contributor

Given that sometimes we don't want to apply any filters, it makes sense to make the param optional. I also fix the typing on paginated_select.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Nov 20, 2024
@dstandish dstandish mentioned this pull request Nov 20, 2024
Open
Lee-W
Lee-W approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good besides changing the var name in list comprehension to x, but I think it's more like a personal taste 🤔

airflow/api_fastapi/core_api/routes/public/dags.py Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/dags.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/event_logs.py Outdated Show resolved Hide resolved
pierrejeambrun
pierrejeambrun reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one question

airflow/api_fastapi/common/db/common.py Outdated Show resolved Hide resolved
amoghrajesh
amoghrajesh reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments, just found the newer version with for x in event_logs or for x in assets etc less readable.

airflow/api_fastapi/common/db/common.py Show resolved Hide resolved
airflow/api_fastapi/common/db/common.py Show resolved Hide resolved
airflow/api_fastapi/common/db/common.py Show resolved Hide resolved
@dstandish
Make filters param optional and fix typing
a52a6d4 
Given that sometimes we don't want to apply any filters, it makes sense to make the param optional.  I also fix the typing on `paginated_select`.
@dstandish dstandish merged commit 22d1406 into apache:main Nov 21, 2024
45 checks passed
@dstandish dstandish deleted the make-filters-optional branch November 21, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoghrajesh amoghrajesh amoghrajesh left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@Lee-W Lee-W Lee-W approved these changes

@ashb ashb ashb left review comments

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

Assignees
No one assigned
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dstandish @ashb @Lee-W @pierrejeambrun @amoghrajesh