-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code from Pagerduty provider #44653
Remove deprecated code from Pagerduty provider #44653
Conversation
Just a static check is failing, when this is fixed I assume this can be merged. |
I have modified test_pagerduty.py and another check has failed due to this statement from providers/src/airflow/providers/pagerduty/hooks/pagerduty.py However, fixing the second static check caused the unit test to fail.
|
Yes, because previously the pytest imported "wrong" as a re-import. In
...and then of course also commit the fix in static checks, easiest run |
Done ! |
Green! Merged! Thanks! |
related: #44559
remove-deprecated-code, remove test ,update changelog from-pagerduty provider
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.