Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code from providers before Airflow 2.11.0 release #44559

Closed
94 tasks done
eladkal opened this issue Dec 2, 2024 · 20 comments
Closed
94 tasks done

Remove deprecated code from providers before Airflow 2.11.0 release #44559

eladkal opened this issue Dec 2, 2024 · 20 comments
Labels
area:providers good first issue kind:meta High-level information important to the community

Comments

@eladkal
Copy link
Contributor

eladkal commented Dec 2, 2024

Body

Following [LAZY CONSENSUS] Remove deprecations from providers prior to Airflow 2.11 release this issue will track the progress of the removal status.

How to remove?

  1. PRs should be easy to review, You can handle more than 1 provider in the same PR but please use judgment about how many files the PR changes. Please use meaningful commit message.
  2. Find all deprecated code in a provider and accommodate for the needed change (normally the code has deprecation warning that indicates what needs to be removed). Make sure you are not removing code that was just deprecated in recent PR and was never released in stable version. Do not bulk remove!
  3. Add entry to CHANGELOG.rst with information about what was removed and how to mitigate (normally it's copy/paste with minor adjustments to the deprecation warning). Use the following blockright after the Changelog line:
main
....

.. warning::
  All deprecated classes, parameters and features have been removed from the {provider_name} provider package.
  The following breaking changes were introduced:

  * what was removed and how to mitigate

  1. If provider was already handled and introduce new deprecation do not remove again (at least not for now).

List of providers:

Maintainers please update the list with the relevant PRs/status

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added area:providers kind:meta High-level information important to the community labels Dec 2, 2024
@Prab-27
Copy link
Contributor

Prab-27 commented Dec 2, 2024

Hello @potiuk I'm a newbie
I would like to confirm whether I should use the v2-10-test branch for this issue since it is related to version 2

@kunaljubce
Copy link
Contributor

@Prab-27 If you're talking about which branch to raise the PR on, that should be main. Refer to the tagged PRs for inspiration.

@kunaljubce
Copy link
Contributor

kunaljubce commented Dec 2, 2024

@eladkal So in the context of this change, are we good to deprecate the Apache Drill provider completely?

class DrillOperator(SQLExecuteQueryOperator):

@ajitg25
Copy link
Contributor

ajitg25 commented Dec 2, 2024

Hello @eladkal @jedcunningham ,
I have raised a PR to remove deprecated code from Airbyte providers.
Please have a look and let me know if anychanges are required.

Thank you for your time!!

@Prab-27
Copy link
Contributor

Prab-27 commented Dec 2, 2024

@eladkal I’m working on the hashicorp provider and will soon raise a PR.

@jscheffl
Copy link
Contributor

jscheffl commented Dec 2, 2024

@eladkal I just checked for the noted deprecations in Celery - these are purely for executor interface, not DAG author specific - and the change was just added and require Airflow 2.10.4 as minimum. If we add a breaking change, Celery can not be upgraded for Airflow 2.10.3 and below.
Therefore I'd recommend to keep the Celery deprecations for a moment. No harm for the intend to help users to migrate.

--> FYI marked as to keep it. Hope it is OK?

@Prab-27
Copy link
Contributor

Prab-27 commented Dec 3, 2024

@jscheffl - How can I determine the version number like 5.0.0 in CHANGELOG.rst?

I believe the version number in CHANGELOG.rst is derived from the next versions mentioned in provider.yaml .

@eladkal
Copy link
Contributor Author

eladkal commented Dec 3, 2024

@jscheffl - How can I determine the version number like 5.0.0 in CHANGELOG.rst?

I believe the version number in CHANGELOG.rst is derived from the next versions mentioned in provider.yaml .

You don't, see the instructions in step 3. You set main not version. The version number is chosen by release manager during release time.

@jason810496
Copy link
Contributor

jason810496 commented Dec 4, 2024

Working on

  • Elasticsearch
  • Jekins
  • Apache Livy
  • Mongo
  • Redis
  • SendGrid
  • DBT
  • Atlassian Jira
  • Common SQL

@kunaljubce
Copy link
Contributor

kunaljubce commented Dec 7, 2024

@eladkal @jscheffl Below have no deprecations. Please update the description -

  • apache.hive
  • apache.flink
  • apache.iceberg
  • apache.impala
  • apache.kafka
  • apache.kylin

@potiuk
Copy link
Member

potiuk commented Dec 7, 2024

Updatiing

@jscheffl
Copy link
Contributor

jscheffl commented Dec 7, 2024

Updatiing

Updating descriptions in Github is a pain. I did it already ~10 times and it seems if others update as well then sometimes (at least 10 times already) my changes are lost. Also notes down a few multiple times which have no deprecations. Tracking a set of PRs on a bug ticket is something Github is not made for :-(

@kunaljubce
Copy link
Contributor

FYI - Working on Apache Drill and Apache Druid deprecations.

@potiuk
Copy link
Member

potiuk commented Dec 7, 2024

Updating descriptions in Github is a pain. I did it already ~10 times and it seems if others update as well then sometimes (at least 10 times already) my changes are lost. Also notes down a few multiple times which have no deprecations. Tracking a set of PRs on a bug ticket is something Github is not made for :-(

What I did it in the past is re-generating those issues automatically from time to time ... Another thing-> I did not link/update the PRs in the list just "clicked" the checkmark - it was good enough usually.

@potiuk
Copy link
Member

potiuk commented Dec 7, 2024

But maybe a good idea is to do (or find?) a small tool that should do such update via API?

say:

breeze check-issue #12345 --item abc --with-pr #27456

😱

That would make it far more usable

@kunaljubce
Copy link
Contributor

@potiuk @jscheffl While we're at it, below also don't have any deprecations -

  • apache.pig
  • apache.pinot
  • apache.cassandra

With the apache.druid PR up, looks like we're done with the Apache series of deprecations :)

@potiuk
Copy link
Member

potiuk commented Dec 7, 2024

Screenshot 2024-12-07 at 21 51 20

🚀

@potiuk
Copy link
Member

potiuk commented Dec 16, 2024

Is it done ?????! ??? 🚀

@potiuk
Copy link
Member

potiuk commented Dec 16, 2024

Shall you do the honors @eladkal and close it ?

@eladkal
Copy link
Contributor Author

eladkal commented Dec 16, 2024

Created a small followup #44807 to make docs better :)

@eladkal eladkal closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:meta High-level information important to the community
Projects
None yet
Development

No branches or pull requests

7 participants