Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider Deprecations in Oracle #44704

Merged

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Dec 5, 2024

In Airflow 3 Dev Call we discussed and made a LAZY CONSENSUS to remove all deprecation's in providers prior 2.11 release in https://lists.apache.org/thread/lhy7zhz8yxo3jjpln0ds8ogszgb9b469.

This PR is for the provider Oracle

Relates to #44559

@jscheffl jscheffl force-pushed the feature/remove-provider-deprecations-oracle branch from c7cc411 to 02584c5 Compare December 5, 2024 21:24
@jscheffl
Copy link
Contributor Author

jscheffl commented Dec 5, 2024

Doc updates please https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-oracle/operators/index.rst?plain=1#L29?

uuups, yeah, totally over-looked this :-( Thanks for the hints!

@gopidesupavan
Copy link
Member

Doc updates please https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-oracle/operators/index.rst?plain=1#L29?

uuups, yeah, totally over-looked this :-( Thanks for the hints!

Better to verifying docs if the deprecation is completely removing the class :)

@jscheffl jscheffl force-pushed the feature/remove-provider-deprecations-oracle branch from 02584c5 to 22da86e Compare December 5, 2024 21:54
@gopidesupavan
Copy link
Member

gopidesupavan commented Dec 6, 2024

@jscheffl it seems the test failures are because of this https://github.com/apache/airflow/pull/44704/files#diff-a1ced97245f107006f7a972734c2e5e7ff79da3816f5762c6c2bc1fc2e17f806R26. may be removing these deprecations providers/src/airflow/providers/common/sql/hooks/sql.py solve ?

@gopidesupavan
Copy link
Member

@jscheffl it seems the test failures are because of this https://github.com/apache/airflow/pull/44704/files#diff-a1ced97245f107006f7a972734c2e5e7ff79da3816f5762c6c2bc1fc2e17f806R26. may be removing these deprecations providers/src/airflow/providers/common/sql/hooks/sql.py solve ?

or is it something related dag versioning

@jscheffl jscheffl added the full tests needed We need to run full set of tests for this PR to merge label Dec 6, 2024
@jscheffl jscheffl force-pushed the feature/remove-provider-deprecations-oracle branch from 22da86e to 0b42915 Compare December 6, 2024 20:51
@jscheffl jscheffl merged commit 1ff9fe8 into apache:main Dec 6, 2024
97 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Remove Provider Deprecations in Oracle

* Remove docs from removed operator and examples
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Remove Provider Deprecations in Oracle

* Remove docs from removed operator and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge provider:oracle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants