Remove Provider Deprecations in Sqlite #44707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 tasks
|
Can you please also update the docs? https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-sqlite/operators.rst?plain=1#L20 |
gopidesupavan
approved these changes
Dec 6, 2024
eladkal
reviewed
Dec 6, 2024
jscheffl
force-pushed
the
feature/remove-provider-deprecations-sqlite
branch
from
fcb0f35 to
71df393
Compare
jscheffl
added
the
full tests needed
jscheffl
force-pushed
the
feature/remove-provider-deprecations-sqlite
branch
from
71df393 to
1bcc328
Compare
12 tasks
eladkal
reviewed
Dec 10, 2024
Comment on lines
-32
to
-33
| @pytest.mark.backend("sqlite") | ||
| class TestSqliteOperator: |
There was a problem hiding this comment.
I wonder if we need to keep these tests?
How do we know SQLExecuteQueryOperator works with sqlite backend if we remove these?
Do we have this coverage elsewhere?
There was a problem hiding this comment.
We have pytests for SQLExecuteQueryOperator and these tests are executed against all DBs we support. I did not check in detail but if you think DB tests are missing... we should add it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Airflow 3 Dev Call we discussed and made a LAZY CONSENSUS to remove all deprecation's in providers prior 2.11 release in https://lists.apache.org/thread/lhy7zhz8yxo3jjpln0ds8ogszgb9b469.
This PR is for the provider Sqlite
Relates to #44559