Remove update-build-dependencies pre-commit #45359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we contributed the fix to dependabot to also bump build-dependencies and having first PRs generated by the dependabot, we can now safely remove the pre-commit. Here is the fix we contributed: dependabot/dependabot-core#10899 Related PRs: apache#45356, apache#45357, apache#45358
|
Hey @ashb -> you wanted this pre-commit removed, so we had first case where after @gopidesupavan contributed the dependabot fix, we finally CAN remove it. |
gopidesupavan
approved these changes
Jan 2, 2025
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
After we contributed the fix to dependabot to also bump build-dependencies and having first PRs generated by the dependabot, we can now safely remove the pre-commit. Here is the fix we contributed: dependabot/dependabot-core#10899 Related PRs: apache#45356, apache#45357, apache#45358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we contributed the fix to dependabot to also bump build-dependencies and having first PRs generated by the dependabot, we can now safely remove the pre-commit.
Here is the fix we contributed:
dependabot/dependabot-core#10899
Related PRs: #45356, #45357, #45358
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.