-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Moving EmptyOperator to standard provider #46231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving EmptyOperator to standard provider #46231
Conversation
|
It needs newsfragment as breaking change for Airflow 3 |
|
@potiuk it'd be nice if you can take a look on this too, since you were involved in the past standard operator moves |
sunank200
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Added few comments
|
@vincbeck we will be adding the migration rules for this as requested. @sunank200 / @Lee-W will be assisting with that. |
You can deploy dag in zip files. |
@amoghrajesh Is it possible for us to zip it through script instead of just uploading a zip file? It's hard to know what's actually inside the zip |
It does yeah, it contains a reference to the older EmptyOperator path, i updated that |
Hmm, its been done this way historically too, I guess we can but I can do it in a follow up if thats ok? I will list the zip changes here: |
Yep, I know it's done this way previously. If this is blocking something, we can create an issue for tracking this and do it in follow up PRs. Thanks! |
|
Yeah, will pick it up @Lee-W. |
|
@amoghrajesh Sorry for the CI error. The fix is created #46404 |
No problem, thanks! I was wondering what the issue was! |
|
Feel free to resolve my comments. I think we're close to merge 🙂 |
Basic dag tested:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.