-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Closed
Labels
area:dev-envCI, pre-commit, pylint and other changes that do not change the behavior of the final codeCI, pre-commit, pylint and other changes that do not change the behavior of the final codearea:dev-toolsgood first issuekind:featureFeature RequestsFeature Requests
Description
Description
We should generate the zip file in our test case (i.e., include the files we want to zip but not the zip file itself) and then do the test instead of uploading it to the repo. Currently, we have the following 2 zip files.
- tests/dags/test_dag_warnings.zip
- tests/dags/test_zip.zip
In addition to it, we should have a pre-commit to avoid someone from commit a zip file.
Use case/motivation
zip files are hard to review and could incur security issues.
Related issues
Are you willing to submit a PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:dev-envCI, pre-commit, pylint and other changes that do not change the behavior of the final codeCI, pre-commit, pylint and other changes that do not change the behavior of the final codearea:dev-toolsgood first issuekind:featureFeature RequestsFeature Requests