Cleanup committed zip file in tests/dags#46604
Merged
Lee-W merged 4 commits intoapache:mainfrom Feb 10, 2025
Merged
Conversation
josix
changed the title
josix
force-pushed
the
refactor/cleanup-persistent-zip-file-in-test-env
branch
3 times, most recently
from
99e823f to
c9b9d77
Compare
josix
force-pushed
the
refactor/cleanup-persistent-zip-file-in-test-env
branch
from
c9b9d77 to
20801d5
Compare
Member
|
Just a quick update for @amoghrajesh . This PR has resolved my previous zip file comment in your PR. |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* refactor: remove test_dag_warning.zip in test_dagbag.py * refactor: add dynamic test_zip_path fixture for generating test zip files * chore: Ignore zip files in .gitignore * fixup! refactor: add dynamic test_zip_path fixture for generating test zip files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the repository
.gitignoreto ignore*.zipfiles (referencing issue Get rid of *.zip in tests cases #46449)test_zip.zipandtest_dag_warnings.zipfromtests/dags/tests/dags/test_zip/test_zip_pathfixture that dynamically creates zip files for testingcloses #46449
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.