Skip to content

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Feb 9, 2025

Adjust some path's in pre-commit config to prevent degrading providers after move.

@potiuk
Copy link
Member

potiuk commented Feb 9, 2025

I was already working on those as part of a bigger cleanup :) but we can have it merged first :)

@jscheffl jscheffl force-pushed the bugfix/adjust-new-provider-structure-in-pre-commit branch from 7234c73 to ad22bcc Compare February 9, 2025 19:34
@jscheffl
Copy link
Contributor Author

jscheffl commented Feb 9, 2025

I was already working on those :) but we can have it merged first :)

Let me know... how far are you? Am I adding extra work to re-base? Are you close-by? :-D

@potiuk
Copy link
Member

potiuk commented Feb 9, 2025

I was already working on those :) but we can have it merged first :)

Let me know... how far are you? Am I adding extra work to re-base? Are you close-by? :-D

Rebaseing is fine - I will rebase mine when ready..

How far I am ? Depends how much wine with my friend we'll have tonight ;).

@jscheffl
Copy link
Contributor Author

jscheffl commented Feb 9, 2025

I was already working on those :) but we can have it merged first :)

Let me know... how far are you? Am I adding extra work to re-base? Are you close-by? :-D

Rebaseing is fine - I will rebase mine when ready..

How far I am ? Depends how much wine with my friend we'll have tonight ;).

Be careful! Don't drink and root. In code this means like "Don't drink and merge"

@potiuk
Copy link
Member

potiuk commented Feb 9, 2025

Be careful! Don't drink and root. In code this means like "Don't drink and merge"

That's it yes. I am trying to hit Ballmer's peak, let's see if it works

@potiuk
Copy link
Member

potiuk commented Feb 9, 2025

image

@jscheffl jscheffl merged commit f409854 into apache:main Feb 9, 2025
44 checks passed
@jscheffl
Copy link
Contributor Author

jscheffl commented Feb 9, 2025

Alcohol-Free merged.

ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
…he#46603)

* Adjust pre-commit config to new provider package path structure

* Review Feedback
@jscheffl jscheffl deleted the bugfix/adjust-new-provider-structure-in-pre-commit branch October 5, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants