Skip to content

Conversation

@insomnes
Copy link
Contributor

@insomnes insomnes commented Feb 10, 2025

During provider migration deprecation warning ignore was wrongly changed due to misconfigured pre-commit hooks.
now there are cases of failing tests on 3.12:

Now that pre-commit hooks are fixed in #46603 the problem with failing pipelines can be addressed too:
We need to ignore the actual DeprecationWarning and not AirflowProviderDeprecationWarning cause it's not the provider deprecation mark but in botocore lib.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the provider:amazon AWS/Amazon - related issues label Feb 10, 2025
@insomnes
Copy link
Contributor Author

insomnes commented Feb 10, 2025

If I understood it correctly changes from here are required first:

#46608

To address other providers deprecation problems in full-tests

@insomnes insomnes force-pushed the fix-amazon-emr-depr-warn branch from 2f56691 to 4eb8a19 Compare February 10, 2025 18:28
@potiuk potiuk force-pushed the fix-amazon-emr-depr-warn branch from 4eb8a19 to d472913 Compare February 10, 2025 19:24
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to get it merged to fix the main failures. But it needs to get green :)

@insomnes
Copy link
Contributor Author

I cannot understand the exact reason for the failure of the check, my initial thought was about deprecations_ignore.yml but it seems unrelated to the AriflowProviderDeprecationsWarning in google tests.

@insomnes
Copy link
Contributor Author

@insomnes
Copy link
Contributor Author

After investigation, I am sure that the problem with google deprecation warning failures is outside of this PR scope, should be fine after #46638 or another PR that would fix the problem

@ashb ashb merged commit 4b65163 into apache:main Feb 11, 2025
59 of 60 checks passed
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
@insomnes insomnes deleted the fix-amazon-emr-depr-warn branch February 17, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants