Adding uuid6 as a dependency for openlineage #46653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Feb 11, 2025
Member
|
Nice. Good one @amoghrajesh. Actually our compatibility tests detected nicely the issue - #43243 added uuid6 as dependency of Airlfow3, and Openlineage started to use it in #45294, so adding dependency to openlineage is what is needed. |
Contributor
Author
|
Thanks! Yeah the compat tests saved us here! |
Contributor
|
thanks @amoghrajesh for the fix 🙂 |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
Contributor
|
openlineage integration for Airflow doesn't import uuid6, unit tests do. Should provider itself declare dependency on uuid6? |
Member
Good point. We should move it to devel-dependencies of openlineage. Will Fix it in a moment. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 6, 2025
Since uuid6 is only used in tests, we should have it as devel dependency in openlineage provider. Follow up after apache#46653
Member
|
#47464 should fix it |
potiuk
added a commit
that referenced
this pull request
Mar 6, 2025
Since uuid6 is only used in tests, we should have it as devel dependency in openlineage provider. Follow up after #46653
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Since uuid6 is only used in tests, we should have it as devel dependency in openlineage provider. Follow up after apache#46653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45294 seemed to add uuid6 in openlineage. This caused failures in tests.
I am not sure if this fix will fix the issue, but trying still.
Example failure https://github.com/apache/airflow/actions/runs/13264109343/job/37028275493
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.