Skip to content

Fix significant format and update the checking script #46752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 3 commits into from
Feb 14, 2025
Merged

Fix significant format and update the checking script #46752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
591ea03
docs(newsfragments): fix existing newsfragment format/
Lee-W Feb 14, 2025
7f6a05f
ci(pre-commit): fix significant newsfragment todo format
Lee-W Feb 14, 2025
249984b
ci(pre-commit): check whether migration rule starts with check list
Lee-W Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions newsfragments/46231.significant.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.. Moving EmptyOperator from Airflow core to the ``standard`` provider.
Moving EmptyOperator from Airflow core to the ``standard`` provider.

.. EmptyOperator has been moved from Airflow core (``airflow.operators directory``) to the ``standard`` provider.
EmptyOperator has been moved from Airflow core (``airflow.operators directory``) to the ``standard`` provider.
For new and existing DAGs, users must import ``EmptyOperator`` from ``airflow.providers.standard.operators.empty``.

* Types of change
Expand All @@ -14,8 +14,6 @@ For new and existing DAGs, users must import ``EmptyOperator`` from ``airflow.pr
* [ ] Dependency changes
* [ ] Code interface changes

.. List the migration rules needed for this change (see https://github.com/apache/airflow/issues/41641)

* Migration rules needed

* ruff
Expand Down
2 changes: 1 addition & 1 deletion newsfragments/46375.significant.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ Any occurrences of the ``secrets_masker`` module will have to be updated from ``

* AIR302

* [ ] ``airflow.utils.log.secrets_masker`` -> ``airflow.sdk.execution_time.secrets_masker``
* [ ] ``airflow.utils.log.secrets_masker`` → ``airflow.sdk.execution_time.secrets_masker``
6 changes: 3 additions & 3 deletions newsfragments/46408.significant.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ If these config options are still present, they will have no effect any longer.

* ``airflow config lint``

* Remove ``[logging] dag_processor_manager_log_location``
* Remove ``[logging] dag_processor_manager_log_stdout``
* Remove ``[logging] log_processor_filename_template``
* [ ] ``[logging] dag_processor_manager_log_location``
* [ ] ``[logging] dag_processor_manager_log_stdout``
* [ ] ``[logging] log_processor_filename_template``
6 changes: 5 additions & 1 deletion scripts/ci/pre_commit/significant_newsfragments_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
{% endfor %}
{%- endfor %}
{%- endif -%}
{% if undone_config_rules -%}
{%- if undone_config_rules %}
======airflow config lint rules======
{% for rule in undone_config_rules %}* {{ rule }}
{% endfor %}
Expand Down Expand Up @@ -148,6 +148,10 @@ def _extract_check_list_item(node: docutils.nodes.Node) -> tuple[bool, str]:
raise ValueError(f"Incorrect format {node.astext()}")

text = node.astext()
if text[0] != "[" or text[2] != "]":
raise ValueError(
f"{text} should be a checklist (e.g., * [ ] ``logging.dag_processor_manager_log_location``)"
)
return text[:3] == "[x]", text[4:]

@property
Expand Down
Loading