Fix significant format and update the checking script #46752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
changed the title
Lee-W
requested review from
amoghrajesh
and removed request for
ashb and
potiuk
alecsg77
pushed a commit
to alecsg77/airflow
that referenced
this pull request
Feb 14, 2025
* docs(newsfragments): fix existing newsfragment format/ * ci(pre-commit): fix significant newsfragment todo format * ci(pre-commit): check whether migration rule starts with check list
messam88
added a commit
to fpopic/airflow
that referenced
this pull request
Feb 17, 2025
* Fix significant format and update the checking script (apache#46752) * docs(newsfragments): fix existing newsfragment format/ * ci(pre-commit): fix significant newsfragment todo format * ci(pre-commit): check whether migration rule starts with check list * Fix gcp auth in hashicorp vault provider. * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * Fix failing gcp test_vault_client tests (#3) * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com> * Fix typo in gcp auth test. * fix syntax and linting --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Filip Popić <filip.popic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some of the todos cannot be listed by
uv run scripts/ci/pre_commit/significant_newsfragments_checker.py --list-todoWhat
manually fix some format and update the checking script to check whether check list exists before migration rules
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.