Fix failing gcp test_vault_client tests #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpopic
added a commit
that referenced
this pull request
Feb 6, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
added a commit
that referenced
this pull request
Feb 6, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
added a commit
that referenced
this pull request
Feb 6, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
messam88
added a commit
that referenced
this pull request
Feb 14, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
messam88
added a commit
that referenced
this pull request
Feb 17, 2025
* Fix significant format and update the checking script (apache#46752) * docs(newsfragments): fix existing newsfragment format/ * ci(pre-commit): fix significant newsfragment todo format * ci(pre-commit): check whether migration rule starts with check list * Fix gcp auth in hashicorp vault provider. * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * Fix failing gcp test_vault_client tests (#3) * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com> * Fix typo in gcp auth test. * fix syntax and linting --------- Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Filip Popić <filip.popic@gmail.com>
fpopic
added a commit
that referenced
this pull request
Feb 17, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
added a commit
that referenced
this pull request
Feb 24, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
added a commit
that referenced
this pull request
Jun 21, 2025
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
added a commit
that referenced
this pull request
Jun 23, 2025
* Fix gcp auth in hashicorp vault provider. * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * Fix failing gcp test_vault_client tests (#3) * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com> * Fix typo in gcp auth test. * fix syntax and linting * Add missing role_id in VaultHook kwargs * Refactor gcp tests. Add missing role_id to test_gcp_init_params. Refactor gcp tests. * Fix open in tests assertions. --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
added a commit
that referenced
this pull request
Jun 23, 2025
* Fix gcp auth in hashicorp vault provider. * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * Fix failing gcp test_vault_client tests (#3) * Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com> * Fix typo in gcp auth test. * fix syntax and linting * Add missing role_id in VaultHook kwargs * Refactor gcp tests. Add missing role_id to test_gcp_init_params. Refactor gcp tests. * Fix open in tests assertions. --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.