Fix gcp auth in hashicorp vault provider. #51991
Conversation
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider.
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:hashicorp
fpopic
force-pushed
the
fix_vault_gcp_auth
branch
3 times, most recently
from
eec4d8e to
55c4039
Compare
fpopic
changed the title
fpopic
changed the title
Add missing role_id to test_gcp_init_params. Refactor gcp tests.
fpopic
force-pushed
the
fix_vault_gcp_auth
branch
from
55c4039 to
9281126
Compare
|
@hussein-awala please review, tests are fixed finally. =) |
|
Thank you @messam88 for co-contribution! @potiuk, @hussein-awala and @pbetkier could you update provider label of (#17500) from |
Sure. Done. |
|
@potiuk What is the usual release cycle for providers? |
You can look it up in the devlis ~ every two weeks but without strict commitment. Generally subscribing to devlist is a good idea - you will also be notified when the release candidate is prepared - and you will have a chance to test your own changes (you will also be tagged). You will find link how to subscribe and see the past communication in "community" tab on our docs page. |
|
And for the future - please avoid tagging individuals for such questions. Ask your question in the PR (as a general question) or in Slack in the appropriate channels. Tagging individual people because you want to grab their attention and have your answer faster is not very well seen in the community. You post your question and let the people who happen to have time and want to spend their free time and energy migh or might not answer. Tagging people if you are not sure they are interested in something is a bad idea, |
3 participants
closes: #17500
continuation of closed stale PRs: #35855, #45457, #46505
@boring-cyborg assign: @fpopic, @messam88 (#35855 (comment))