Fix hashicorp provider vault gcp auth (stale 3) #46505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpopic
force-pushed
the
fix_vault_gcp_auth
branch
from
112bdc5 to
374cb03
Compare
potiuk
approved these changes
Feb 6, 2025
Member
|
A number of tests/checks to fix though :) |
fpopic
force-pushed
the
fix_vault_gcp_auth
branch
from
374cb03 to
e062803
Compare
aaabramov
reviewed
Feb 11, 2025
providers/hashicorp/src/airflow/providers/hashicorp/_internal_client/vault_client.py
Outdated
Show resolved
Hide resolved
messam88
force-pushed
the
fix_vault_gcp_auth
branch
from
e062803 to
0ea53ac
Compare
Contributor
|
Hello @potiuk @hussein-awala Could you have another round of review? |
fpopic
force-pushed
the
fix_vault_gcp_auth
branch
from
73eb20b to
40d5b83
Compare
potiuk
force-pushed
the
fix_vault_gcp_auth
branch
from
40d5b83 to
102d776
Compare
Member
|
I am afraid the tests are failing. Rebased it to check but look like problems to be solved. |
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider.
* Fix vault gcp auth. * Prepare jwt in test. * Fix gcp auth in hashicorp vault provider. * remove redundent code * fix failing tests --------- Co-authored-by: Mohamed Morsy <messam88@gmail.com>
fpopic
force-pushed
the
fix_vault_gcp_auth
branch
from
eeae3f6 to
3566858
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
fpopic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of closed PR: #35855
@boring-cyborg assign: @fpopic, (@messam88 #35855 (comment) - thank you!)