-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix hashicorp provider vault gcp auth (stale 1) #35855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f005459 to
c7f269a
Compare
bcf2bb0 to
e4fc0e8
Compare
| creds = json.load(f) | ||
| service_account = creds['client_email'] | ||
|
|
||
| # Generate a payload for subsequent "signJwt()" call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check whether can airflow.utils.jwt_signer.JWTSigner be reused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
reopen |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
reopen |
|
Very need this fix. Vault gcp-auth method is not working at all. |
|
@Taragolis could you please reopen and please assign me and @messam88 (he will write here request for assignment by himself). I updated branch with latest changes in my fork fpopic/airflow but seems in origin apache/airflow I don't see the latest change in PR, guess cause the PR is closed? |
|
@Taragolis Hey Taragolis could you please reopen it and assign it to me as well |
closes : #17500
Reused the code that works in Cloud Functions
Similar example