Skip to content

Conversation

@fpopic
Copy link
Contributor

@fpopic fpopic commented Nov 25, 2023

@fpopic fpopic force-pushed the main branch 7 times, most recently from f005459 to c7f269a Compare November 26, 2023 00:17
@fpopic fpopic changed the title Fix vault gcp auth. Fix vault gcp auth Nov 26, 2023
@fpopic fpopic changed the title Fix vault gcp auth [WIP] Fix vault gcp auth Nov 26, 2023
@fpopic fpopic force-pushed the main branch 2 times, most recently from bcf2bb0 to e4fc0e8 Compare November 26, 2023 00:28
creds = json.load(f)
service_account = creds['client_email']

# Generate a payload for subsequent "signJwt()" call
Copy link
Contributor Author

@fpopic fpopic Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check whether can airflow.utils.jwt_signer.JWTSigner be reused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 11, 2024
@github-actions github-actions bot closed this Jan 17, 2024
@fpopic
Copy link
Contributor Author

fpopic commented Jan 17, 2024

reopen

@Taragolis Taragolis reopened this Jan 17, 2024
@github-actions github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jan 18, 2024
@github-actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 3, 2024
@github-actions github-actions bot closed this Mar 9, 2024
@fpopic fpopic changed the title [WIP] Fix vault gcp auth [WIP] Fix hashicorp provider vault gcp auth Sep 22, 2024
@fpopic
Copy link
Contributor Author

fpopic commented Sep 22, 2024

reopen
please triage with hashicorp provider

@algoru
Copy link

algoru commented Nov 18, 2024

Very need this fix. Vault gcp-auth method is not working at all.

@fpopic
Copy link
Contributor Author

fpopic commented Dec 15, 2024

@Taragolis could you please reopen and please assign me and @messam88 (he will write here request for assignment by himself). I updated branch with latest changes in my fork fpopic/airflow but seems in origin apache/airflow I don't see the latest change in PR, guess cause the PR is closed?

@messam88
Copy link
Contributor

messam88 commented Jan 7, 2025

@Taragolis Hey Taragolis could you please reopen it and assign it to me as well

@fpopic fpopic changed the title [WIP] Fix hashicorp provider vault gcp auth Fix hashicorp provider vault gcp auth Jan 14, 2025
@fpopic fpopic changed the title Fix hashicorp provider vault gcp auth Fix hashicorp provider vault gcp auth (stale 1) Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect implementation of GCP auth type in VaultBackend?

4 participants