Set task/dag labels for Dataproc Batch #46781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:google
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
force-pushed
the
batch_set_airflow_labels
branch
from
7a9ebdd to
83161b4
Compare
|
This looks good to me - @VladaZakharova let's have someone in the team review as well. |
Member
|
Needs rebase :) |
Contributor
|
Looks good to me! (Although needs rebase) @potiuk Can you please approve and merge, if it looks good to you? Thanks :) |
ntr
requested review from
Fokko,
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
mik-laj,
mobuchowski,
o-nikolas,
pierrejeambrun,
potiuk,
ryanahamilton and
uranusjr
as code owners
ntr
force-pushed
the
batch_set_airflow_labels
branch
from
58530bc to
f522fa4
Compare
Contributor
Author
|
Thanks, updated. |
VladaZakharova
approved these changes
Feb 21, 2025
eladkal
requested changes
Feb 21, 2025
eladkal
removed request for
XD-DENG,
bbovenzi,
bolkedebruin,
dstandish,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
mik-laj,
mobuchowski,
o-nikolas and
pierrejeambrun
eladkal
reviewed
Feb 21, 2025
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py
Show resolved
Hide resolved
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Beside Elad's comment, code looks good.
potiuk
approved these changes
Feb 24, 2025
ntr
force-pushed
the
batch_set_airflow_labels
branch
from
f522fa4 to
b8fdcb9
Compare
medb
approved these changes
Feb 25, 2025
Member
|
anything remaining @eladkal :)? |
potiuk
force-pushed
the
batch_set_airflow_labels
branch
from
d91b5fb to
3a25cd3
Compare
Contributor
Author
|
@eladkal can you please take a look again? I cannot merge this PR without your approval. Thanks. |
eladkal
approved these changes
Mar 9, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
azharizz
pushed a commit
to azharizz/airflow
that referenced
this pull request
Mar 9, 2025
…pache#46781) * Set task/dag labels for Dataproc Batch * Adding airflow-dag-display-name label support
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…pache#46781) * Set task/dag labels for Dataproc Batch * Adding airflow-dag-display-name label support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set task/dag id labels for Dataproc Batch
Setting labels
airflow-dagandairflow-taskusing sanitized dag and task id. This should help the users to keep track of historical execution of dataproc serverless batches.User can use those labels to cluster dataproc batches by dags and tasks, perform historical analysis and navigate to the airflow source code.
During discussion, we considered alternative of using 'dag-display-name' but there is not enforcement for it to be a unique.
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.