Skip to content

Conversation

@cnauroth
Copy link
Contributor

@cnauroth cnauroth commented Sep 2, 2025

As per
Dataproc documentation the maximum length for a label value is 63.
DataprocCreateBatchOperator performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 2, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 2, 2025
@cnauroth
Copy link
Contributor Author

cnauroth commented Sep 2, 2025

@ntr FYI

As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
@cnauroth cnauroth force-pushed the dataproc-label-length branch from c7e8321 to 61ccea7 Compare September 2, 2025 23:44
@cnauroth
Copy link
Contributor Author

cnauroth commented Sep 3, 2025

Hello @michalmodras , @potiuk , @eladkal and @medb. I noticed you were the reviewers on the original #46781 that added task/dag labels to Dataproc batches. Are you available to code review this bug fix? Thank you.

@potiuk potiuk merged commit 394820b into apache:main Sep 4, 2025
77 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 4, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@cnauroth
Copy link
Contributor Author

cnauroth commented Sep 4, 2025

@potiuk , really appreciate it. Thank you!

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Sep 8, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
As per
[Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels)
the maximum length for a label value is 63.
`DataprocCreateBatchOperator` performs validation to prevent setting
longer labels. However, the regex currently allows 64 characters, which
causes a failure when trying to create the batch. Update the regex and
unit tests to enforce a max of 63.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants