-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Validate Dataproc batch labels max 63 characters #55196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
@ntr FYI |
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
c7e8321 to
61ccea7
Compare
|
Hello @michalmodras , @potiuk , @eladkal and @medb. I noticed you were the reviewers on the original #46781 that added task/dag labels to Dataproc batches. Are you available to code review this bug fix? Thank you. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
@potiuk , really appreciate it. Thank you! |
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per [Dataproc documentation](https://cloud.google.com/dataproc/docs/guides/creating-managing-labels) the maximum length for a label value is 63. `DataprocCreateBatchOperator` performs validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.
As per
Dataproc documentation the maximum length for a label value is 63.
DataprocCreateBatchOperatorperforms validation to prevent setting longer labels. However, the regex currently allows 64 characters, which causes a failure when trying to create the batch. Update the regex and unit tests to enforce a max of 63.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.