Remove references of "airflow.www" in FAB provider #46914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great cleaning! Should we include this part in this PR or another one? Edit: |
jedcunningham
approved these changes
Feb 20, 2025
Member
|
My 2c, a follow up for those would be better. |
Contributor
|
Great, make sense! Was just wondering your ideas. Thanks! :) |
Contributor
Author
Agree, I'd like to do it once the UI is removed, which is not done yet :) |
vincbeck
force-pushed
the
vincbeck/fab-www
branch
5 times, most recently
from
9f1fec2 to
f0cb48b
Compare
hussein-awala
approved these changes
Feb 20, 2025
vincbeck
force-pushed
the
vincbeck/fab-www
branch
2 times, most recently
from
a861500 to
ce7685b
Compare
vincbeck
force-pushed
the
vincbeck/fab-www
branch
from
ce7685b to
76a4e92
Compare
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old UI is getting removed in #46871. Some tests are failing because
airflow.wwwis being used in FAB provider and it should not. Remove these references.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.