Add missing methodtools dependency of the common-sql provider

[tatiana]

Since apache-airflow-providers-common-sql==1.23.0, released on 26 February 2025, users started facing the error:

    from cosmos.operators._asynchronous.bigquery import DbtRunAirflowAsyncBigqueryOperator
cosmos/operators/_asynchronous/bigquery.py:8: in <module>
    from airflow.providers.google.cloud.operators.bigquery import BigQueryInsertJobOperator
../../../.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.12-2.9/lib/python3.12/site-packages/airflow/providers/google/cloud/operators/bigquery.py:32: in <module>
    from airflow.providers.common.sql.operators.sql import (  # type: ignore[attr-defined] # for _parse_boolean
../../../.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.12-2.9/lib/python3.12/site-packages/airflow/providers/common/sql/operators/sql.py:[29](https://github.com/astronomer/astronomer-cosmos/actions/runs/13544957799/job/37854234771#step:6:30): in <module>
    from airflow.providers.common.sql.hooks.sql import DbApiHook, fetch_all_handler, return_single_query_results
../../../.local/share/hatch/env/virtual/astronomer-cosmos/Za_bFbg4/tests.py3.12-2.9/lib/python3.12/site-packages/airflow/providers/common/sql/hooks/sql.py:37: in <module>
    from methodtools import lru_cache
E   ModuleNotFoundError: No module named 'methodtools'

When trying to import:

from airflow.providers.google.cloud.operators.bigquery import BigQueryInsertJobOperator

It seems this started happening since #41327.

This PR aims to solve this issue.

Closes: #47147

[dabla]

Indeed since 41327 I've added the lru cache for use with dialects. Isn't there a way to detect such missing dependency when running the tests of the provider?

[gopidesupavan]

I believe we moved adding dependency to provider info and pyproject.toml files, so IMHO It would be better to add this dependency to pyproject.toml https://github.com/apache/airflow/blob/main/providers/common/sql/pyproject.toml#L57

Then the pre-commit will add that to readme and provider info file https://github.com/apache/airflow/blob/main/providers/common/sql/src/airflow/providers/common/sql/get_provider_info.py

[potiuk]

I believe we moved adding dependency to provider info and pyproject.toml files, so IMHO It would be better to add this dependency to pyproject.toml https://github.com/apache/airflow/blob/main/providers/common/sql/pyproject.toml#L57

Yep. This is the new (much more standard) way how we should add dependencies. In fact I am a little puzzled why this PR did not fail with validation of the provider.yaml, because ... it should ... We do not exapect dependencies field in provider.yaml any more. Let me see why it did not fail.

[potiuk]

OK. I know ... Missing case for selective checks

[potiuk]

The #47148 improves selective checks to cover that case.

[potiuk]

Requesting changes to avoid accidental merge.

[tatiana]

Thank you very much, @dabla, @gopidesupavan, and @potiuk, for the rapid reviews and feedback!

I moved the dependency from provider.yaml to pyproject.toml in e7a6619.

I noticed the following files were modified after running the pre-commit checks:

generated/provider_dependencies.json
providers/common/sql/README.rst
providers/common/sql/src/airflow/providers/common/sql/get_provider_info.py

For now, I have added them to the PR. Please let me know if that's correct - I can remove them if necessary.

[potiuk]

For now, I have added them to the PR. Please let me know if that's correct - I can remove them if necessary.

Yep. This is exactly what pre-commits are doing - take your change and apply whatever resulting changes elsewhere are needed so that you do not have to even think about it.

[dabla]

Awesome to see how quickly this issue has been resolved 👍

[potiuk]

The static-checks error is likely from main

[potiuk]

The static check failure handled in #47172