Skip to content

Add missing methodtools dependency of the common-sql provider #47148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Feb 27, 2025
Merged

Add missing methodtools dependency of the common-sql provider #47148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2447310
Add methodtools as a dependency of the common-sql provider
tatiana Feb 27, 2025
20e3a23
Fix linting
tatiana Feb 27, 2025
e7a6619
Revert change to provider.yaml and applyc hange to pyproject.toml
tatiana Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions generated/provider_dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@
"common.sql": {
"deps": [
"apache-airflow>=2.9.0",
"methodtools>=0.4.7",
"more-itertools>=9.0.0",
"sqlparse>=0.5.1"
],
Expand Down
1 change: 1 addition & 0 deletions providers/common/sql/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ PIP package Version required
``apache-airflow`` ``>=2.9.0``
``sqlparse`` ``>=0.5.1``
``more-itertools`` ``>=9.0.0``
``methodtools`` ``>=0.4.7``
================== ==================

Cross provider package dependencies
Expand Down
3 changes: 3 additions & 0 deletions providers/common/sql/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ dependencies = [
"apache-airflow>=2.9.0",
"sqlparse>=0.5.1",
"more-itertools>=9.0.0",
# The methodtools dependency is necessary since the introduction of dialects:
# https://github.com/apache/airflow/pull/41327/files
"methodtools>=0.4.7"
]

# The optional dependencies should be modified in place in the generated file
Expand Down
7 changes: 6 additions & 1 deletion providers/common/sql/src/airflow/providers/common/sql/get_provider_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ def get_provider_info():
"sensors": [
{"integration-name": "Common SQL", "python-modules": ["airflow.providers.common.sql.sensors.sql"]}
],
"dependencies": ["apache-airflow>=2.9.0", "sqlparse>=0.5.1", "more-itertools>=9.0.0"],
"dependencies": [
"apache-airflow>=2.9.0",
"sqlparse>=0.5.1",
"more-itertools>=9.0.0",
"methodtools>=0.4.7",
],
"optional-dependencies": {
"pandas": ["pandas>=2.1.2,<2.2"],
"openlineage": ["apache-airflow-providers-openlineage"],
Expand Down
Loading