Skip to content

Conversation

@jscheffl
Copy link
Contributor

Migrated #47158 to apache repo

Follow-up of #46942

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools labels Feb 27, 2025
@jscheffl jscheffl mentioned this pull request Feb 27, 2025
@jscheffl jscheffl added legacy ui Whether legacy UI change should be allowed in PR legacy api Whether legacy API changes should be allowed in PR labels Feb 27, 2025
@jscheffl jscheffl closed this Feb 27, 2025
@jscheffl jscheffl reopened this Feb 27, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment

@jscheffl
Copy link
Contributor Author

GREEN

@potiuk potiuk merged commit 65d0098 into main Mar 1, 2025
89 checks passed
@potiuk
Copy link
Member

potiuk commented Mar 1, 2025

Booom. -7.500 lines :)

@potiuk
Copy link
Member

potiuk commented Mar 1, 2025

The smaller brother.

image

@jscheffl
Copy link
Contributor Author

jscheffl commented Mar 1, 2025

Booom. -7.500 lines :)

Was 12k LoC before when the opanapi spec YAML was also deleted, so once we switch the client to the new API spec this is another opportunity to clean :-D

@vincbeck vincbeck deleted the delete-api_connexion branch March 3, 2025 14:49
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Mar 5, 2025

---------

Co-authored-by: vincbeck <vincbeck@amazon.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jscheffl Why did we leave this one schema file behind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs a final cleanup... had some dependency outside... and search revealed .... in: airflow/cli/commands/remote_commands/dag_command.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me have a PR raised in a moment for final cleanup...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final Connexion cleanup: #47490

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice.

nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025

---------

Co-authored-by: vincbeck <vincbeck@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:dev-tools legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants