-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove api_connexion
#47171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove api_connexion
#47171
Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a comment
|
GREEN |
|
Booom. -7.500 lines :) |
Was 12k LoC before when the opanapi spec YAML was also deleted, so once we switch the client to the new API spec this is another opportunity to clean :-D |
--------- Co-authored-by: vincbeck <vincbeck@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jscheffl Why did we leave this one schema file behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one needs a final cleanup... had some dependency outside... and search revealed .... in: airflow/cli/commands/remote_commands/dag_command.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me have a PR raised in a moment for final cleanup...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final Connexion cleanup: #47490
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nice.
--------- Co-authored-by: vincbeck <vincbeck@amazon.com>

Migrated #47158 to apache repo
Follow-up of #46942