-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove old UI and webserver #46942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old UI and webserver #46942
Conversation
|
So we don't loose it from the original PR: #protm! |
|
Now we removed www, FAB is not automatically set up for tests. This is causing problems in FAB provider tests. |
|
I'm starrting to take a look into failing breeze tests... |
|
I did too @jscheffl -> fixed some more |
I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact. |
fab provider is added as amazon's optional dependency -> that triggers the tests transitively |
|
I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked |
I think it's a matter of adding the right fixture to |
|
@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though? |
Looks nice. I am not aware of anything that can achieve this in the new web stack. |
|
Looking promising ! |
|
Wow! Looks pretty green now! Should we maybe run "full tests" and "all version" before merge?
|
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all changed files... looks good! (besides the other comments open)
|
All good - it should be ✅ hopefully - all remaining things in comments. |
|
End of an era, amazing work! |
|
🎉 🎉 |
|
Wow. I did not expect it gets merged this week :-D Good job! |
|
Beta release today sped up the work :) |
Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Jed Cunningham <jedcunningham@apache.org> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: vincbeck <vincbeck@amazon.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: vatsrahul1001 <43964496+vatsrahul1001@users.noreply.github.com> Co-authored-by: GPK <gopidesupavan@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
After apache#46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.
|
Well done! |
Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Jed Cunningham <jedcunningham@apache.org> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> Co-authored-by: vincbeck <vincbeck@amazon.com> Co-authored-by: Jens Scheffler <jscheffl@apache.org> Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> Co-authored-by: vatsrahul1001 <43964496+vatsrahul1001@users.noreply.github.com> Co-authored-by: GPK <gopidesupavan@gmail.com> Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
…pache#47202) After apache#46942 - we should wait for UI not WWW asset compilation in the start-airlfow command.

Try to strip out as much of the old webserver and UI as possible for AIP-79.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.