Skip to content

Conversation

@bbovenzi
Copy link
Contributor

excited-fuego

Try to strip out as much of the old webserver and UI as possible for AIP-79.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jedcunningham
Copy link
Member

So we don't loose it from the original PR: #protm!

@Lee-W Lee-W self-requested a review February 21, 2025 03:15
@uranusjr
Copy link
Member

uranusjr commented Feb 21, 2025

Now we removed www, FAB is not automatically set up for tests. This is causing problems in FAB provider tests.

@jscheffl
Copy link
Contributor

I'm starrting to take a look into failing breeze tests...

@potiuk
Copy link
Member

potiuk commented Feb 21, 2025

I did too @jscheffl -> fixed some more

@jscheffl
Copy link
Contributor

I did too @jscheffl -> fixed some more

I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact.

@potiuk
Copy link
Member

potiuk commented Feb 21, 2025

I was unsure and wated to contact you.... but you fixed what I suspected and wondered why this was the impact.

fab provider is added as amazon's optional dependency -> that triggers the tests transitively

@jscheffl
Copy link
Contributor

I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked app based on appbuilder+Flask can be replicated over. I fear either we need to re-write a lot of tests or we need to add the dependency to FAB provider... which is also not helpful.
A common solution would be great but I am lagging an idea.

@potiuk
Copy link
Member

potiuk commented Feb 23, 2025

I was attempting to make some fixes to the pytests failing, but I am missing an idea how the previous mocked app based on appbuilder+Flask can be replicated over. I fear either we need to re-write a lot of tests or we need to add the dependency to FAB provider... which is also not helpful.
A common solution would be great but I am lagging an idea.

I think it's a matter of adding the right fixture to tests_common so that it can be used with those tests - following the new "fast_api" way of initializing the app, but I also lack a bit of understanding how it is done now without doing a lot of digging

@jedcunningham
Copy link
Member

@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though?

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Feb 24, 2025

@pierrejeambrun @bbovenzi take a look at 6a01eaa - I didn't want to tackle a general "build arbitrary url" helper, so I just did dagrun. Is there something existing for this use case though?

Looks nice. I am not aware of anything that can achieve this in the new web stack.

@potiuk
Copy link
Member

potiuk commented Feb 24, 2025

Looking promising !

@jscheffl
Copy link
Contributor

jscheffl commented Feb 26, 2025

Wow! Looks pretty green now! Should we maybe run "full tests" and "all version" before merge?

e.g. K8s tests seem not to be fired in the pipeline... --> Ah, they are "just pending"...

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all changed files... looks good! (besides the other comments open)

@potiuk
Copy link
Member

potiuk commented Feb 26, 2025

All good - it should be ✅ hopefully - all remaining things in comments.

@jedcunningham jedcunningham merged commit 5141554 into main Feb 27, 2025
148 checks passed
@bbovenzi
Copy link
Contributor Author

gif

@bbovenzi bbovenzi deleted the remove-legacy-ui branch February 27, 2025 02:00
@bugraoz93
Copy link
Contributor

End of an era, amazing work!

@pierrejeambrun
Copy link
Member

🎉 🎉

@jscheffl
Copy link
Contributor

Wow. I did not expect it gets merged this week :-D Good job!

@jscheffl jscheffl mentioned this pull request Feb 27, 2025
@potiuk
Copy link
Member

potiuk commented Feb 27, 2025

Beta release today sped up the work :)

ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 28, 2025
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 28, 2025
Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Co-authored-by: Jed Cunningham <jedcunningham@apache.org>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: vincbeck <vincbeck@amazon.com>
Co-authored-by: Jens Scheffler <jscheffl@apache.org>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Co-authored-by: vatsrahul1001 <43964496+vatsrahul1001@users.noreply.github.com>
Co-authored-by: GPK <gopidesupavan@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
potiuk added a commit to potiuk/airflow that referenced this pull request Feb 28, 2025
After apache#46942 - we should wait for UI not WWW asset compilation in
the start-airlfow command.
potiuk added a commit that referenced this pull request Feb 28, 2025
…47202)

After #46942 - we should wait for UI not WWW asset compilation in
the start-airlfow command.
@shahar1
Copy link
Contributor

shahar1 commented Mar 1, 2025

Well done!

nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Co-authored-by: Jed Cunningham <jedcunningham@apache.org>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: vincbeck <vincbeck@amazon.com>
Co-authored-by: Jens Scheffler <jscheffl@apache.org>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Co-authored-by: vatsrahul1001 <43964496+vatsrahul1001@users.noreply.github.com>
Co-authored-by: GPK <gopidesupavan@gmail.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
…pache#47202)

After apache#46942 - we should wait for UI not WWW asset compilation in
the start-airlfow command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI area:dev-tools area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.