-
Notifications
You must be signed in to change notification settings - Fork 16.4k
AIP-84 | Add Auth for Config #47208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 | Add Auth for Config #47208
Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, one nit that should be good to figure out. Basically the permission decorator should not change the openapi spec. (beside the auth scheme)
c9bbbef to
87f0452
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, need rebase.
87f0452 to
b18f228
Compare
b18f228 to
77e94c0
Compare
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need rebase to solve conflicts.
77e94c0 to
94e326c
Compare
|
The CI error persists. That's weird |
|
it's not the config that is problematic now: |
Thanks to point it out, let me take a look at python client test and fix it. |
94e326c to
87736b5
Compare
87736b5 to
df667fb
Compare
|
I have a fix for Tests / CI image checks / Test Python API client (pull_request) basically that is not specifically related to this PR. The test is just broken at the moment. (passing on main but not testing anything) |
df667fb to
12bdc65
Compare
|
As this has been approved and full test passed, I'm merging this one |
* AIP-84 | Add Auth for Config * Fix requires_access_configuration schema * Refactor requires_access_configuration with lambda
related: #42360
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.