Skip to content

Fix test_python_client.py #47460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Mar 6, 2025
Merged

Fix test_python_client.py #47460

potiuk merged 1 commit into from
Mar 6, 2025

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Mar 6, 2025 •
edited
Loading

Clean the module

  • TriggerDagRun failures are not omitted anymore (logical date is passed down and we are not receiving a 422 anymore)
  • Use the appropriate AuthManager, the server is actually using FabAuthManager so we cannot be using the SimpleAuthManager to generate the token on the client side. AIP-84 | Fix test_python_client after Adding Permission to API #47388 just didn't work and it was highlighted in AIP-84 | Add Auth for Config #47208.
  • Updated the doc following the auth backend removal and use of AuthManager token generation instead.

@pierrejeambrun pierrejeambrun self-assigned this Mar 6, 2025
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 6, 2025
@pierrejeambrun pierrejeambrun mentioned this pull request Mar 6, 2025
Merged
@potiuk potiuk merged commit 3bcc725 into apache:main Mar 6, 2025
35 checks passed
@jason810496
Copy link
Member

jason810496 commented Mar 7, 2025

Thank @pierrejeambrun! I forgot that the server is actually using FabAuthManager, and should set token in headers instead of api_key 😓

@jason810496 jason810496 mentioned this pull request Mar 7, 2025
Closed
47 tasks
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
@pierrejeambrun @nailo2c
Fix test_python_client.py (apache#47460)
463293e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@shahar1 shahar1 shahar1 approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

+1 more reviewer

@enchant3dmango enchant3dmango enchant3dmango approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pierrejeambrun pierrejeambrun

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pierrejeambrun @jason810496 @potiuk @enchant3dmango @shahar1