feat(api_fastapi): include asset id in asset nodes when calling "/ui/dependencies" and "/ui/structure/structure_data" #47381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bbovenzi
reviewed
Mar 5, 2025
Lee-W
force-pushed
the
set-dep-id-to-asset-id-for-asset-dag-dep
branch
11 times, most recently
from
da2032a to
9b0e3f7
Compare
Member
Author
|
@bbovenzi this PR is somewhat blocked by #47484 (review) and will need to rework partially due to #47320. so we'll need more time to get it ready |
Lee-W
force-pushed
the
set-dep-id-to-asset-id-for-asset-dag-dep
branch
from
9b0e3f7 to
05eb7d0
Compare
uranusjr
reviewed
Mar 10, 2025
uranusjr
reviewed
Mar 10, 2025
uranusjr
reviewed
Mar 10, 2025
Lee-W
force-pushed
the
set-dep-id-to-asset-id-for-asset-dag-dep
branch
from
05eb7d0 to
33da3c8
Compare
Contributor
|
I just noticed that |
1 task
Lee-W
force-pushed
the
set-dep-id-to-asset-id-for-asset-dag-dep
branch
7 times, most recently
from
3c12b45 to
12056bc
Compare
Merged
… type to be asset_id
…endencies to retreive needed info only
…ref to asset-name-ref and asset-uri-ref
Lee-W
force-pushed
the
set-dep-id-to-asset-id-for-asset-dag-dep
branch
from
4614b33 to
7b2de24
Compare
Member
Author
|
as the latest version resolve all the comments and this PR is approved, I'll merge it once ci passes |
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
…dependencies" and "/ui/structure/structure_data" (apache#47381) * feat(serialization): change dependency_id in DagDependency with asset type to be asset_id * feat(dag_dependency): add label * test(serialization): fix test_derived_dag_deps_sensor * test(serialization): fix test_dag_deps_assets_with_duplicate_asset * test: fix test_derived_dag_deps_operator * test(task_sdk): fix task_sdk tests due to _resolve_assets renaming * test(api_fastapi/ui): fix test cases * test(serialized_dag): fix test_order_of_deps_is_consistent * feat(dot_renderer): support label * refactor: refactor retreive_asset_models as resolve_assets_as_dag_dependencies to retreive needed info only * feat: remove db access in serialized object * feat(dag_dependency): improve dependency_type typing and split asset-ref to asset-name-ref and asset-uri-ref * feat(serialized_dag): resolve dag dependency to include asset id * refactor(serialized_dag): extract dag dependency resolving logic as a class * test(dag_serialization): fix dag_serialization tests * test(api_fastapi): update test cases with asset_id changes * test(api_fastapi): fix test case with dynamic asset id * fix(serialized_dag): fix postgrest dag dep handling * Fix asset graph in UI * test(api_fastapi): fix structure endpoint test case * fix(api_fastapi): fix /ui/structure --------- Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Mar 22, 2025
…dependencies" and "/ui/structure/structure_data" (apache#47381) * feat(serialization): change dependency_id in DagDependency with asset type to be asset_id * feat(dag_dependency): add label * test(serialization): fix test_derived_dag_deps_sensor * test(serialization): fix test_dag_deps_assets_with_duplicate_asset * test: fix test_derived_dag_deps_operator * test(task_sdk): fix task_sdk tests due to _resolve_assets renaming * test(api_fastapi/ui): fix test cases * test(serialized_dag): fix test_order_of_deps_is_consistent * feat(dot_renderer): support label * refactor: refactor retreive_asset_models as resolve_assets_as_dag_dependencies to retreive needed info only * feat: remove db access in serialized object * feat(dag_dependency): improve dependency_type typing and split asset-ref to asset-name-ref and asset-uri-ref * feat(serialized_dag): resolve dag dependency to include asset id * refactor(serialized_dag): extract dag dependency resolving logic as a class * test(dag_serialization): fix dag_serialization tests * test(api_fastapi): update test cases with asset_id changes * test(api_fastapi): fix test case with dynamic asset id * fix(serialized_dag): fix postgrest dag dep handling * Fix asset graph in UI * test(api_fastapi): fix structure endpoint test case * fix(api_fastapi): fix /ui/structure --------- Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…dependencies" and "/ui/structure/structure_data" (apache#47381) * feat(serialization): change dependency_id in DagDependency with asset type to be asset_id * feat(dag_dependency): add label * test(serialization): fix test_derived_dag_deps_sensor * test(serialization): fix test_dag_deps_assets_with_duplicate_asset * test: fix test_derived_dag_deps_operator * test(task_sdk): fix task_sdk tests due to _resolve_assets renaming * test(api_fastapi/ui): fix test cases * test(serialized_dag): fix test_order_of_deps_is_consistent * feat(dot_renderer): support label * refactor: refactor retreive_asset_models as resolve_assets_as_dag_dependencies to retreive needed info only * feat: remove db access in serialized object * feat(dag_dependency): improve dependency_type typing and split asset-ref to asset-name-ref and asset-uri-ref * feat(serialized_dag): resolve dag dependency to include asset id * refactor(serialized_dag): extract dag dependency resolving logic as a class * test(dag_serialization): fix dag_serialization tests * test(api_fastapi): update test cases with asset_id changes * test(api_fastapi): fix test case with dynamic asset id * fix(serialized_dag): fix postgrest dag dep handling * Fix asset graph in UI * test(api_fastapi): fix structure endpoint test case * fix(api_fastapi): fix /ui/structure --------- Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need asset ID to fetch asset details in UI
closes: #47163
What
idwill be updated as asset_id, andlabelis set to asset_nameidis still task_ide whilelabelis set to task_display_name^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.