Move asset evaluation logic out of SDK #47484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
move-asset-evaluate-to-scheduler
branch
from
13f856c to
b56d68e
Compare
1 task
Member
Author
|
I added an additional commit to remove db calls in |
Lee-W
approved these changes
Mar 7, 2025
ashb
approved these changes
Mar 7, 2025
uranusjr
force-pushed
the
move-asset-evaluate-to-scheduler
branch
2 times, most recently
from
040895a to
e44a50c
Compare
Asset evaluation is only done in the scheduler, and requires the database in various cases. It is better to split it out into a dedicated class in Airflow core.
Dependency resolution requires database calls for non-direct asset references, but we don't want that to happen in the SDK. This removes the eager resolution code so all asset aliases and refs are no longer resolved, but one only keeps a marker for itself. An additional PR will be submitted later to do the resolution. This is a part of the asset UI project that involves changes in the API anyway.
uranusjr
force-pushed
the
move-asset-evaluate-to-scheduler
branch
from
e44a50c to
d9acd62
Compare
github-project-automation
bot
moved this to Done
in AIP-72 - Task Execution Interface and SDK
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Asset evaluation is only done in the scheduler, and requires the database in various cases. It is better to split it out into a dedicated class in Airflow core. Dependency resolution requires database calls for non-direct asset references, but we don't want that to happen in the SDK. This removes the eager resolution code so all asset aliases and refs are no longer resolved, but one only keeps a marker for itself. An additional PR will be submitted later to do the resolution. This is a part of the asset UI project that involves changes in the API anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset evaluation is only done in the scheduler, and requires the database in various cases. It is better to split it out into a dedicated class in Airflow core.
Close #47378
Fix #47483