Remove auth backends from core Airflow #47399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
from
eb33142 to
39914ba
Compare
Member
|
Don't forget the config option too: airflow/airflow/config_templates/config.yml Line 1376 in aa24dab |
bugraoz93
approved these changes
Mar 5, 2025
Contributor
That also has a test. Just to point out :) airflow/tests/core/test_configuration.py Line 617 in 3a300c9 While checking, I saw this one 😕 I will create a small PR for fixing the syntax (indentation). airflow/tests/core/test_configuration.py Lines 642 to 646 in 3a300c9 |
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
from
39914ba to
062e1cb
Compare
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
2 times, most recently
from
a66d256 to
27a66f3
Compare
Contributor
Author
|
We actually need to keep the config. APIs provided by the FAB auth manager (such as users, roles, ...) need the auth backends. These APIs have not been migrated to fastapi and are still using Flask. Therefore, they need the auth backends. I updated the config description to reflect that. |
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
from
27a66f3 to
fdff271
Compare
Contributor
Author
|
However, we probably should move the config to FAB provider then? Edit: I moved it. |
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
12 times, most recently
from
c670c7c to
676f387
Compare
Contributor
Author
|
Test failures are not related to this PR, finally all tests are passing! Reviews are welcome :) |
vincbeck
requested review from
ashb and
jedcunningham
and removed request for
ashb and
jedcunningham
pierrejeambrun
approved these changes
Mar 12, 2025
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
from
676f387 to
6b4ed42
Compare
bugraoz93
approved these changes
Mar 12, 2025
vincbeck
force-pushed
the
vincbeck/auth_backends
branch
from
6b4ed42 to
7011715
Compare
Contributor
Author
|
Error unrelated to this PR. Merging |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
This was referenced Apr 6, 2025
potiuk
added a commit
to jason810496/airflow
that referenced
this pull request
Apr 12, 2025
Some recent changes in main and documentation published in the inventories, made the 2.10 doc building fail as references to non-existing docs in the new inventories were still used in the documentation for 2.10 This PR fixes it by changing the docs to not refer to those changed docs any more. The PRs that removed the links: apache#47320 and apache#47399 Co-authored-by: LIU ZHE YOU <zhu424.dev@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to jason810496/airflow
that referenced
this pull request
Apr 12, 2025
Some recent changes in main and documentation published in the inventories, made the 2.10 doc building fail as references to non-existing docs in the new inventories were still used in the documentation for 2.10 This PR fixes it by changing the docs to not refer to those changed docs any more. The PRs that removed the links: apache#47320 and apache#47399 Co-authored-by: LIU ZHE YOU <zhu424.dev@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
to jason810496/airflow
that referenced
this pull request
Apr 12, 2025
Some recent changes in main and documentation published in the inventories, made the 2.10 doc building fail as references to non-existing docs in the new inventories were still used in the documentation for 2.10 This PR fixes it by changing the docs to not refer to those changed docs any more. The PRs that removed the links: apache#47320 and apache#47399 Co-authored-by: LIU ZHE YOU <zhu424.dev@gmail.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Apr 12, 2025
Some recent changes in main and documentation published in the inventories, made the 2.10 doc building fail as references to non-existing docs in the new inventories were still used in the documentation for 2.10 This PR fixes it by changing the docs to not refer to those changed docs any more. The PRs that removed the links: #47320 and #47399 Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth backends are non longer used in Airflow 3. We should remove them. This also help to remove Flask from core Airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.