Skip to content

Conversation

@jason810496
Copy link
Member

related: #48404

What

Fix Building docs CI on v2-10-test branch.

@jason810496 jason810496 requested a review from potiuk as a code owner March 31, 2025 10:48
@jason810496 jason810496 changed the title Fix/v2-10-test/build-docs [v2-10-test] Fix Building docs CI Mar 31, 2025
@jason810496 jason810496 marked this pull request as draft April 9, 2025 02:52
@potiuk
Copy link
Member

potiuk commented Apr 9, 2025

FYI: WARNING: undefined label: 'config:celery__worker_precheck -> this is likely the culprit.

@jason810496
Copy link
Member Author

jason810496 commented Apr 10, 2025

Sorry @potiuk, I might not be able to resolve this 😢 and may need your help to carry it forward 🙏

FYI: WARNING: undefined label: 'config:celery__worker_precheck' -> this is likely the culprit.

Agree, I also think this to be the root cause of the docs build failure.
I’ve been digging through the related Celery provider config and its worker_precheck context in both the main and v2-10-test branches over the past couple of days but haven’t found anything helpful so far...

@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

Taking a look now

@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

The problem is caused by #47320 - it removed worker_precheck command from celery configuration, yet in 2.10.0 we still refer to it - there was an old confifuration core/woreer_precheck that has been renamed to celery/worker_precheck - which is now gone from celery.

@potiuk potiuk force-pushed the fix/v2-10-test/build-docs branch 2 times, most recently from a50cafa to f4c8dcb Compare April 12, 2025 13:37
@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

I think this one should work now there was also another change #47399 that removed authentication backends recently and it also had to be fixed.

@potiuk potiuk marked this pull request as ready for review April 12, 2025 13:39
@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

Ok. Docs building is fixed - there was a temp issue on downloading inventory. Also mypy issue fixed separatelu in #49156 - ther was also a core celery test issue, but this one should be treated separtaely

@potiuk potiuk force-pushed the fix/v2-10-test/build-docs branch from f4c8dcb to 5b9d80a Compare April 12, 2025 14:21
@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

Actually - the celery failure might be related.. Let me see

Some recent changes in main and documentation published in the
inventories, made the 2.10 doc building fail as references to
non-existing docs in the new inventories were still used in the
documentation for 2.10

This PR fixes it by changing the docs to not refer to those
changed docs any more.

The PRs that removed the links: apache#47320 and apache#47399

Co-authored-by: LIU ZHE YOU <zhu424.dev@gmail.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@potiuk potiuk force-pushed the fix/v2-10-test/build-docs branch from 5b9d80a to ee7ae9c Compare April 12, 2025 14:47
@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

Tried alternative approach

@potiuk
Copy link
Member

potiuk commented Apr 12, 2025

Worked.

@potiuk potiuk merged commit b910b10 into apache:v2-10-test Apr 12, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants