Update documentation priority weight#47529
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the improvement in docs!
|
@ninsbl reported on the issue that is possibly a bug rather than just a doc update. Is that still the case? |
|
For me the change is okay. To be on the safe side... one improvement idea: Can you add the code snippet rather as a new example DAG (e.g. name it In the past such example DAG was not added because plugins/extensions were not loaded by default, but this has changed since then. So adding an example DAG might be a good option nowadays. |
|
sure @jscheffl , i already update the code to add example dags. Also for the test on the dag and documentation using breeze there is no issue regarding this custom weight rule |
docs/apache-airflow/administration-and-deployment/priority-weight.rst
Outdated
Show resolved
Hide resolved
* Prepare docs for Mar 1st wave of providers
…pache#46781) * Set task/dag labels for Dataproc Batch * Adding airflow-dag-display-name label support
…ist (apache#47517) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…ors using task SDK (apache#47548)
- add system test - update docs - add sources to the build jar file Co-authored-by: Oleg Kachur <kachur@google.com>
|
thanks for the review @jscheffl , i have changed the code |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
|
Nice. Thanks, @azharizz ! |
closes: #46824
link
I have already tried the custom weight rule on my local environment, and it is applicable. However, the code block inside it is not the same as the code above. So i try to fix it with add some command airflow plugins to see list plugin created.