-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Updating EC2 Operators and Sensors with AWS Base classes #47931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o-nikolas
reviewed
Mar 19, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise looks good! (Need to fix failing static checks though)
o-nikolas
approved these changes
Mar 21, 2025
eladkal
approved these changes
Mar 21, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
* Update ec2 opereator with AwsBaseOperator * Update ec2 sensor with AWS base class * Use AWS Base classes in EC2 operators and sensors * Fixing static check issues * PR feedback changes --------- Co-authored-by: mse139 <mse139@users.noereply.github.com>
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Mar 22, 2025
* Update ec2 opereator with AwsBaseOperator * Update ec2 sensor with AWS base class * Use AWS Base classes in EC2 operators and sensors * Fixing static check issues * PR feedback changes --------- Co-authored-by: mse139 <mse139@users.noereply.github.com>
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Update ec2 opereator with AwsBaseOperator * Update ec2 sensor with AWS base class * Use AWS Base classes in EC2 operators and sensors * Fixing static check issues * PR feedback changes --------- Co-authored-by: mse139 <mse139@users.noereply.github.com>
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated EC2 Operators to inherit base AWS Operator, and updated Sensors to inherit Base AWS Sensor. I did not update the Trigger, as it wasn't using the standard waiter.
Partially address #35278