Change version handling in provider documentation to packaging version #48249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
gopidesupavan and
jedcunningham
as code owners
ashb
approved these changes
Mar 25, 2025
amoghrajesh
approved these changes
Mar 25, 2025
Member
Looks like it’s still not parsed right. |
gopidesupavan
approved these changes
Mar 25, 2025
We have been using SemVer to handle version updates in provider documentation breeze commands, which started to break at the moment we started to have pre-release packages - Puthon packaging follows PEP-440 and it is implemented in packaging.version module. This module does not have all the nice features semver has (like bumping the major/minor/patchlevel versions so we had to implement it ourselves (packaging Versions are immutable and we need to recreate the version after bump.
potiuk
force-pushed
the
change_version_handling_from_semver_to_packaging
branch
from
42590e8 to
8511da3
Compare
Member
Author
Indeed . Should be fixed. kinda surprising to see tuple there, and int in dev , but makes sense for sorting and the like |
kaxil
approved these changes
Mar 25, 2025
Member
Author
|
ok. Looks good. Merging |
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
apache#48249) We have been using SemVer to handle version updates in provider documentation breeze commands, which started to break at the moment we started to have pre-release packages - Puthon packaging follows PEP-440 and it is implemented in packaging.version module. This module does not have all the nice features semver has (like bumping the major/minor/patchlevel versions so we had to implement it ourselves (packaging Versions are immutable and we need to recreate the version after bump.
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
apache#48249) We have been using SemVer to handle version updates in provider documentation breeze commands, which started to break at the moment we started to have pre-release packages - Puthon packaging follows PEP-440 and it is implemented in packaging.version module. This module does not have all the nice features semver has (like bumping the major/minor/patchlevel versions so we had to implement it ourselves (packaging Versions are immutable and we need to recreate the version after bump.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
apache#48249) We have been using SemVer to handle version updates in provider documentation breeze commands, which started to break at the moment we started to have pre-release packages - Puthon packaging follows PEP-440 and it is implemented in packaging.version module. This module does not have all the nice features semver has (like bumping the major/minor/patchlevel versions so we had to implement it ourselves (packaging Versions are immutable and we need to recreate the version after bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using SemVer to handle version updates in provider documentation breeze commands, which started to break at the moment we started to have pre-release packages - Puthon packaging follows PEP-440 and it is implemented in packaging.version module.
This module does not have all the nice features semver has (like bumping the major/minor/patchlevel versions so we had to implement it ourselves (packaging Versions are immutable and we need to recreate the version after bump.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.